Lazy path pieces #154
Merged
Lazy path pieces #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=========================================
- Coverage 95.31% 95.3% -0.01%
=========================================
Files 35 35
Lines 3200 3197 -3
=========================================
- Hits 3050 3047 -3
Misses 150 150
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Prevents the library from tokenizing the URL of each http request. The URL is now tokenized when a read of the tokenized version is requested.
Quantitative Performance Benefits
Through callgrind we observed this operation was representing ~10% of the total processing cost of a request. This change eliminates it unless explicitly requested.
Possible Drawbacks
Multiple calls to the getter method are now more costly because the value is not cached.
Verification Process
Unit/integ tests. Validation of the approach through ab and callgrind.
Release Notes
The URL is now tokenized lazily when a read of the tokenized version is requested.